output: wlr_renderer_begin with physical size#66
Conversation
The rendered region size is independent on the output transform and scale. Until now, an output with scale > 1 would render only its (1 / scale) part; so with a scale of 2, only the top-left quarter (ie. the left 1/2 of the top 1/2) would be visible. Similarly, a portrait output (constructed as landscape, rotated by 90 degrees) would have an empty area at its bottom. This bug was found while testing the output-management PR (#62).
buffet
approved these changes
Jul 25, 2022
ghost
deleted the
buffet
added a commit
that referenced
this pull request
Nov 15, 2024
buffet
added a commit
that referenced
this pull request
Aug 14, 2025
buffet
added a commit
that referenced
this pull request
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rendered region size is independent on the output transform and
scale. Until now, an output with scale > 1 would render only its
(1 / scale) part; so with a scale of 2, only the top-left quarter (ie.
the left 1/2 of the top 1/2) would be visible.
Similarly, a portrait output (constructed as landscape, rotated by 90
degrees) would have an empty area at its bottom.
This bug was found while testing the output-management PR (#62).